You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
torchx.__version__ and torchx.__image__ should be consistent. Currently version is obtained by torchx.__version__ but image is torchx.version.TORCHX_IMAGE.
Detailed Proposal
Add import torchx.version.TORCHX_IMAGE to the root __init__.py file so that TORCHX_IMAGE can be referenced as torchx.__image__. (In addition we should make torchx.__version__ and torchx.__image__ reflect FB version and image when used internally (and not from github or pip)).
Motivation/Background
Once this is done we can change all references to TORCHX_IMAGE in the builtin components which would make them work in oss and also at fb (since presumably torchx.__image__ would point to ghcr.io docker image for oss and our internal package at fb).
Alternatives
N/A
Additional context/links
N/A
The text was updated successfully, but these errors were encountered:
Generally __foo__ style strings are reserved for internal python known keywords. Could potentially be confusing if a user sees __image__ and assumes it's some builtin python language feature.
Description
torchx.__version__
andtorchx.__image__
should be consistent. Currently version is obtained bytorchx.__version__
but image istorchx.version.TORCHX_IMAGE
.Detailed Proposal
Add
import torchx.version.TORCHX_IMAGE
to the root__init__.py
file so thatTORCHX_IMAGE
can be referenced astorchx.__image__
. (In addition we should maketorchx.__version__
andtorchx.__image__
reflect FB version and image when used internally (and not from github or pip)).Motivation/Background
Once this is done we can change all references to
TORCHX_IMAGE
in the builtin components which would make them work in oss and also at fb (since presumablytorchx.__image__
would point to ghcr.io docker image for oss and our internal package at fb).Alternatives
N/A
Additional context/links
N/A
The text was updated successfully, but these errors were encountered: