Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.12] Release Tracker #5396

Closed
jdsgomes opened this issue Feb 9, 2022 · 7 comments
Closed

[v0.12] Release Tracker #5396

jdsgomes opened this issue Feb 9, 2022 · 7 comments

Comments

@jdsgomes
Copy link
Contributor

jdsgomes commented Feb 9, 2022

We cut a release branch for the 0.12 release.

This issue is for tracking cherry-picks to the release branch.
The POC for the TorchVision team is @jdsgomes

Cherry-Pick Criteria

Phase 1 (until 02/17/22):

Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent minor release (e.g. 0.11 for 0.12 release);
  2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Fixes to new features introduced in the most recent minor release (e.g. 0.11 for 0.12 release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
  7. Release branch specific changes (e.g. change version identifiers)

Phase 2 (after 02/17/22):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.12
    git checkout release/0.12
    git cherry-pick abcdef12345
    
    # Submit a PR based against 'release/1.12' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/1.12
  3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 
  1. the POC will reply with approved / denied or ask for more information.
  2. If approved, the PR can be merged once the tests pass.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.12

@NicolasHug
Copy link
Member

First one!

Link to landed master PR : #5391

Link to release branch PR: #5397

Criteria Category: 2 - critical fix for BC

@jdsgomes jdsgomes pinned this issue Feb 9, 2022
@NicolasHug
Copy link
Member

Another one!

Link to landed master PR : #5428
Link to release branch PR: #5429

Criteria Category: 2 and 4 - Fix for documentation

@jdsgomes
Copy link
Contributor Author

New cherrypick

Link to landed master PR: #5427
Link to release branch PR: #5434

Criteria Category: 4 fix for tests

@jdsgomes
Copy link
Contributor Author

Another one:

Link to landed master PR: #5433
Link to release branch PR: #5437

Criteria Category: 5

@jdsgomes
Copy link
Contributor Author

jdsgomes commented Feb 24, 2022

New cherrypick

landed master PR: #5451
release branch PR: #5467

Criteria Category: 4

@datumbox
Copy link
Contributor

Link to landed main PR: #5470
Link to release branch PR: #5471

Criteria Category: 4 fix for CI tests

@jdsgomes
Copy link
Contributor Author

jdsgomes commented Feb 24, 2022

Link to landed main PR: #5472
Link to release branch PR: #5474

Criteria Category: 2 Critical fix (class should not be exposed at package level)

@pmeier pmeier unpinned this issue May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants