-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of LAMB optimizer #6868
Comments
Are you still working on this issue? |
@Dsantra92 Yes |
Is anyone currently working on this, or can I plan to work on it? |
@ashikshafi08 Go ahead and implement it as I don't have the bandwidth to do so. |
I am not sure where would I push this code. Like under what directory should the optimizers go in? |
@ashikshafi08 See this PR which is in progress for adding LARS. pytorch/pytorch#88106 |
Hey! To set some expectations on this from the core side: we currently do not have much review bandwidth for optimizers and so it may take a while for us to get around to verifying whether LAMB should live in core and then reviewing a LAMB implementation. |
🚀 The feature
#6323 Mentions that torchvision is looking to implement LAMB optimizer.
@datumbox I would very much like to take this issue and create a PR.
Motivation, pitch
LAMB optimizer was created because LARS optimizer performed poorly on model with attention mechanism (mainly). LAMB has shown to achieve very good performance gains across various tasks and I believe that it should be implemented in torchvision.
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: