Typos in calibration coefficients

[carloshorn]

I have written a script to convert PATMOS-x coefficients from tar balls as provided on their official website to PyGAC json files as introduced in #58.
After testing the script with the coefficient version which should correspond to the current PyGAC coefficients, I noticed some typos which I would like to correct with a PR.

1. MetOp-A, channel 3a, slope parameter s1
   

   pygac/pygac/calibration.py

   Lines 56 to 57 in 2d7fbaf

   	'bh': np.array([0.609, 0.980, -0.016]),
   	'bl': np.array([0.609, 0.980, -0.016]),

   
   Last value should be 1.224 instead of -0.016 according to metopa coeffs

    0.030    1.224   -0.033      ! ch3a low gain S0,S1,S2
    0.213    1.224   -0.033     ! ch3a high gain S0,S1,S2

2. NOAA-10, channel 4, non-linear correction parameter b2
   

   pygac/pygac/calibration.py

   Line 214 in 2d7fbaf

   'b2': np.array([0.0, 0.0005885, 0.0005882]),

   
   Second value should be 0.0005882 instead of 0.0005885 according to noaa10 coeffs

 -7.29 5.76 -0.1157  0.0005882  !ch4 nonlinear rad coef (Ns,b0,b1,b2)   (JT) 

3. NOAA-10, channel 4, space radiance
   

   pygac/pygac/calibration.py

   Line 207 in 2d7fbaf

   'n_s': np.array([0.0, -7.27, -7.29]),

   
   Second value should be -7.29 instead of -7.27 according to noaa10 coeffs

 -7.29 5.76 -0.1157  0.0005882  !ch4 nonlinear rad coef (Ns,b0,b1,b2)   (JT) 

4. NOAA-14, channel 5, measured to effective black body temperature intercept
   

   pygac/pygac/calibration.py

   Line 278 in 2d7fbaf

   'a': np.array([1.885330, 0.308384, 0.022171]),

   
   Last value should be -0.022171 (negative) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa14 coeffs

0.022171    !a1_5

5. NOAA-17, channel 3b, measured to effective black body temperature intercept
   

   pygac/pygac/calibration.py

   Line 352 in 2d7fbaf

   'a': np.array([1.70002941, 0.56634758, 0.37264803]),

   
   First value should be 1.7002941 instead of 1.70002941 (too many zeros) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa17 coeffs

-1.7002941  !a1_3b

6. NOAA-6, channel 1, slope parameter s0
   

   pygac/pygac/calibration.py

   Lines 101 to 102 in 2d7fbaf

   	'noaa6': {'ah': np.array([0.133, 0.128, 0.10]),
   	'al': np.array([0.133, 0.128, 0.10]),

   
   The first value in each array should be 0.113 instead of 0.133 according to noaa6 coeffs

    0.113    0.900    0.000       ! ch1 low gain S0,S1,S2
    0.113    0.900    0.000      ! ch1 high gain S0,S1,S2

7. NOAA-6, thermometer 1, PRT parameter d0
   

   pygac/pygac/calibration.py

   Lines 109 to 113 in 2d7fbaf

   	'd': np.array([[0, 0, 0, 0, 0], # reset prt
   	[277.659, 0.051275, 1.363e-06, 0, 0],
   	[276.659, 0.051275, 1.363e-06, 0, 0],
   	[276.659, 0.051275, 1.363e-06, 0, 0],
   	[276.659, 0.051275, 1.363e-06, 0, 0]]),

   
   The second row, first column in array should be 276.659 instead of 277.659 according to noaa6 coeffs

276.659 0.051275 1.363e-06 0.0 0.0 !PRT1 coefficients 

8. NOAA-8, channel 3b, measured to effective black body temperature intercept
   

   pygac/pygac/calibration.py

   Line 162 in 2d7fbaf

   'a': np.array([1.76641050, 0.50017997, 0.50017997]),

   
   First value should be 1.7002941 instead of 1.70002941 (too many zeros) (beside the division by the slope, see channel 4 BT to radiance conversion #57 ) according to noaa8 coeffs

-1.7764105  !a1_3b  

9. TIROS-N, channel 4 and 5, centroid wavenumber
   

   pygac/pygac/calibration.py

   Line 92 in 2d7fbaf

   'c_wn': np.array([2655.7409, 913.0537, 913.0537]),

   
   Second and third value should be 913.05397 instead of 913.0537 according to tirosn coeffs

913.05397   !nu_4
...
913.05397   !nu_5

10. TIROS-N, thermometer 1, PRT parameter d0
    

    pygac/pygac/calibration.py

    Lines 86 to 90 in 2d7fbaf

    	'd': np.array([[0, 0, 0, 0, 0], # reset prt
    	[277.659, 0.051275, 1.363e-06, 0, 0],
    	[276.659, 0.051275, 1.363e-06, 0, 0],
    	[276.659, 0.051275, 1.363e-06, 0, 0],
    	[276.659, 0.051275, 1.363e-06, 0, 0]]),

    
    The second row, first column in array should be 276.659 instead of 277.659 according to tirosn coeffs

276.659 0.051275 1.363e-06 0.0 0.0 !PRT1 coefficients 

I will create a PR, once #58 is merged into master, because I got these differences when comparing the current json files with the one that I produced from the tar ball on the PATMOS-x website.

[sfinkens]

👍 Nice catches! And very tedious work... Thanks!

[mraspaud]

@abhaydd any comments?

[abhaydd]

Agree with @sfinkens Nice catches and fixes :) Thanks a lot @carloshorn and @mraspaud