Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the omerc-bb area to use a sphere as ellps #1072

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 12, 2020

This fixes problems at the poles with folding of the omerc-based areas.
See OSGeo/PROJ#1922 for more details.

@mraspaud mraspaud self-assigned this Feb 12, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.857% when pulling 9c5dad7 on mraspaud:fix-omerc-fold into eae41fa on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #1072 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1072   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         192      192           
  Lines       29517    29517           
=======================================
  Hits        26228    26228           
  Misses       3289     3289           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae41fa...9c5dad7. Read the comment docs.

@TAlonglong
Copy link
Collaborator

Hm, not sure I like it, but I guess this a limitation in the implementation of the omerc, so for long passes this is needed.

Copy link
Collaborator

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@mraspaud mraspaud merged commit 817a900 into pytroll:master Feb 12, 2020
@mraspaud mraspaud deleted the fix-omerc-fold branch February 12, 2020 09:43
@mraspaud mraspaud added the bug label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants