New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pytest in CI and add unstable dependency environment #1095
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
+ Coverage 88.94% 89.31% +0.36%
==========================================
Files 194 195 +1
Lines 29823 28749 -1074
==========================================
- Hits 26526 25677 -849
+ Misses 3297 3072 -225
Continue to review full report at Codecov.
|
CodeFactor is running python 2 checks when it doesn't need to. I'm not sure I feel like making a pylint config just to correct it (I assume it will stop these checks eventually). It is made at me for reusing the builtin |
The coverage difference worries me. It looks like some of the tests aren't being run any more. First guess is my changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the comprehensive clean up! I just found a copy-paste error that needs to be fixed (not you doing though :) )
Co-Authored-By: Martin Raspaud <martin.raspaud@smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendous! Thanks a lot!
FYI Martin approved on slack. So merging now. |
This PR follows our general pytroll trend of moving to pytest for running tests. It also addresses the issue in #1059 about having an environment that installs development versions of xarray and dask and other libraries.
flake8 satpy