Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pytest in CI and add unstable dependency environment #1095

Merged
merged 21 commits into from Mar 2, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 28, 2020

This PR follows our general pytroll trend of moving to pytest for running tests. It also addresses the issue in #1059 about having an environment that installs development versions of xarray and dask and other libraries.

@djhoese djhoese added the enhancement code enhancements, features, improvements label Feb 28, 2020
@djhoese djhoese self-assigned this Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1095 into master will increase coverage by 0.36%.
The diff coverage is 99.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
+ Coverage   88.94%   89.31%   +0.36%     
==========================================
  Files         194      195       +1     
  Lines       29823    28749    -1074     
==========================================
- Hits        26526    25677     -849     
+ Misses       3297     3072     -225
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_geocat.py 100% <ø> (ø) ⬆️
satpy/tests/reader_tests/test_slstr_l2.py 100% <ø> (+2.22%) ⬆️
satpy/tests/compositor_tests/__init__.py 100% <ø> (+0.38%) ⬆️
satpy/tests/reader_tests/test_aapp_l1b.py 100% <ø> (ø) ⬆️
satpy/tests/reader_tests/test_iasi_l2.py 98.61% <ø> (+0.59%) ⬆️
satpy/tests/writer_tests/__init__.py 100% <ø> (+6.25%) ⬆️
satpy/tests/writer_tests/test_ninjotiff.py 100% <ø> (ø) ⬆️
satpy/resample.py 90.76% <ø> (+0.13%) ⬆️
satpy/tests/reader_tests/__init__.py 100% <ø> (+1.49%) ⬆️
satpy/tests/reader_tests/test_eps_l1b.py 100% <ø> (ø) ⬆️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33506e2...6ec63d5. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 28, 2020

Coverage Status

Coverage increased (+0.4%) to 89.3% when pulling 6ec63d5 on djhoese:testing-pytest into 33506e2 on pytroll:master.

@djhoese
Copy link
Member Author

djhoese commented Feb 28, 2020

CodeFactor is running python 2 checks when it doesn't need to. I'm not sure I feel like making a pylint config just to correct it (I assume it will stop these checks eventually). It is made at me for reusing the builtin reduce name...but in python reduce isn't builtin, it has to be imported from functools...which is what I'm doing.

@djhoese
Copy link
Member Author

djhoese commented Feb 29, 2020

The coverage difference worries me. It looks like some of the tests aren't being run any more. First guess is my changes to isinstance where it was using six.text_types.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the comprehensive clean up! I just found a copy-paste error that needs to be fixed (not you doing though :) )

satpy/tests/writer_tests/test_simple_image.py Outdated Show resolved Hide resolved
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous! Thanks a lot!

@djhoese
Copy link
Member Author

djhoese commented Mar 2, 2020

FYI Martin approved on slack. So merging now.

@djhoese djhoese merged commit 7bd69da into pytroll:master Mar 2, 2020
@djhoese djhoese deleted the testing-pytest branch March 2, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test against xarray master
5 participants