Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XRImage producing read-only data arrays and switch to pytest #63

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 29, 2020

I know this is a lot for one PR but the bug that I'm actually fixing is only an issue with the dev version of xarray so I needed to rework the travis config anyway. So I used the opportunity to update tests to use pytest.

This "bug" is due to a recent change in xarray's expand_dims producing read-only arrays: pydata/xarray#3813

This is showing up in pytroll/satpy#1095 for one of the enhancement tests in Satpy.

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@djhoese djhoese added the bug label Feb 29, 2020
@djhoese djhoese self-assigned this Feb 29, 2020
@coveralls
Copy link

coveralls commented Feb 29, 2020

Coverage Status

Coverage increased (+0.4%) to 90.619% when pulling 34e2445 on djhoese:bugfix-expand-dims-readonly into 103b269 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one inline question.
Also, should we add this classifier to setup.py: Programming Language :: Python :: 3 :: Only ?

.travis.yml Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented Mar 2, 2020

I don't think the classifier is needed.

@djhoese djhoese merged commit e590645 into pytroll:master Mar 2, 2020
@djhoese djhoese deleted the bugfix-expand-dims-readonly branch March 2, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants