Remove 1-D lat/lon variables from mimic reader's available datasets #1392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
+ Coverage 90.56% 90.59% +0.03%
==========================================
Files 228 229 +1
Lines 33406 34190 +784
==========================================
+ Hits 30254 30975 +721
- Misses 3152 3215 +63
Continue to review full report at Codecov.
|
djhoese
changed the title
djhoese
changed the title
|
Yes. It seems that it was that simple, which makes me nervous that I actually missed something. However, I checked with a high and low resolution file, along with the test data. I should probably create a second test dataset to replicate the lower resolution files now that I think of it. |
|
How do I put a hold on this request until I can make sure the testing files are working correctly? I thought they were passing, but they just were not running due to a missing package. |
|
I'm not sure if it's visible to you, but there's a |
|
@pnuu Thanks! |
…nd different array sizes.
… to the endian of the machine and could fail without necessity.
…float values to a timedelta so that the timed grids can be plotted directly along with the other dataset_ids without causing an error all_available_ids() are generally loaded and saved using the Scene object.
…s for the mimic tpwGrids which specifies a colormap for all the fields.
Just fullfilling the don't use rainbow requirement. Use spectral with reverse=True but keep rainbow handy because that is currently the colormap used for MIMIC diagnostic images on the archive.
Checking for a netCDF variable before adding attributes is a poor way of avoiding an error when running the test dataset. Instead, check for attributes associated with the variable when it is read and update the metadata appropriately.
Rearrange how the units are defined to better replicate the real datasets. Add check for units.
|
I restarted the failed Linux build on Travis, the |
|
I know the colormap stuff was sub-optimal but I think this is a good workaround. Thanks for all the work. |
Removes the 1-D lat/lon variables from the mimic reader yaml so that lat/lon values are only used as coordinates and do not appear in the available_dataset_ids list.