Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eccodes-based tests after 2.19.0 release #1408

Closed
wants to merge 3 commits into from

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 19, 2020

Eccodes version 2.19.0 seems to break in conjuction with python-eccodes 2020.06. This works around the issue by pinning eccodes to 2.18.0

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1408   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files         228      228           
  Lines       33430    33430           
=======================================
  Hits        30278    30278           
  Misses       3152     3152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2948936...6b87a9c. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 19, 2020

Coverage Status

Coverage increased (+0.9%) to 90.571% when pulling 6b87a9c on mraspaud:fix-eccodes-2.19 into 2948936 on pytroll:master.

@mraspaud
Copy link
Member Author

Reported upstream: ecmwf/eccodes-python#38

@mraspaud
Copy link
Member Author

python-eccodes 2020.10.0 is now available on conda forge and fixes the problem.

@mraspaud mraspaud closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants