-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite installation instructions to make conda use clearer #1711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 258 258
Lines 38273 38273
=======================================
Hits 35376 35376
Misses 2897 2897
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
doc/source/install.rst
Outdated
@@ -47,7 +28,7 @@ you haven't created and activated one already, you can by running: | |||
|
|||
.. code-block:: bash | |||
|
|||
$ conda create -n my_satpy_env python | |||
$ conda create -c conda-forge -n my_satpy_env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to advise to install satpy
directly at env creation to make the installation faster? Or add a short comment like "It is also possible to define all the wanted packages in the environment creation command, which makes the installation faster and might solve some dependency issues between package versions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point. I'll see if I can restructure this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one comment.
Could the second note link to the |
And the notes are fine. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We generally tell new users to use conda for installing Satpy. This PR rearranges the installation instructions so conda comes before pip and also adds information about miniconda.