Fix ReflectanceCorrector (crefl) for MODIS data #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure how to test this...ugh I guess I could rewrite all the tests. Darn it. |
Codecov Report
@@ Coverage Diff @@
## main #1808 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 265 265
Lines 39180 39191 +11
=======================================
+ Hits 36415 36426 +11
Misses 2765 2765
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mraspaud
approved these changes
Aug 27, 2021
|
Thanks, just needed a second set of eyes on it. |
1 task
simonrp84
pushed a commit
to simonrp84/satpy
that referenced
this pull request
Nov 24, 2021
* Fix ReflectanceCorrector (crefl) for MODIS data * Update crefl tests to include tbase.hdf based tests * Refactor crefl tests * Remove duplicate imports from crefl tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apparently misread my original code when porting the crefl code for reading the DEM data. The file used for MODIS (tbase.hdf) has a different variable name and doesn't have a fill value. This PR fixes that.