Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composites failing when inputs are different chunk sizes #1812

Closed
wants to merge 5 commits into from

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 30, 2021

While working on using the CREFL rayleigh correction on MODIS data I noticed a couple issues. This PR fixes:

  1. The variable name was incorrect for the DEM file typically used with MODIS data (tbase.hdf)
  2. The tbase.hdf file doesn't have a fill value specified so it was causing the code to fail when reading it.
  3. Any composites that use map_blocks or blockwise will fail if they have different chunk sizes for their inputs. This is happening for MODIS data due to the angle datasets being returned as 64-bit floats when they only need to be 32-bit floats (that'll be another PR). Anyway, I've added a unify_chunks method that is automatically run as part of match_data_arrays that all Composites typically follow.
  • Tests added

@djhoese
Copy link
Member Author

djhoese commented Aug 30, 2021

🤦‍♂️ I already made #1808 which includes these commits. Let me redo this.

@djhoese djhoese closed this Aug 30, 2021
@djhoese djhoese deleted the bugfix-modis-crefl branch August 30, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant