Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip day and night composites after enhancement #192

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 15, 2018

This PR fixes the DayNightCompositor for channels with fixed stretching for which can have values exceeding 1.0 after enhancement. Those larger-than-assumed values will cause problems when blending (solar zenith angle weighed average) with another channel.

  • Tests passed
  • Passes git diff origin/develop **/*py | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.581% when pulling e5f832b on bugfix-DNC into 985cce1 on maint/0.8.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.581% when pulling e5f832b on bugfix-DNC into 985cce1 on maint/0.8.

@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 60.581% when pulling e5f832b on bugfix-DNC into 985cce1 on maint/0.8.

@pnuu
Copy link
Member Author

pnuu commented Feb 15, 2018

The flake8 test outputs these (unrelated to my little fix) warnings after suppressing the default maximum line length warnings:

$ git diff origin/develop **/*py | flake8 --diff --max-line-length=120
satpy/__init__.py:7:15: W291 trailing whitespace
satpy/__init__.py:11:1: W293 blank line contains whitespace
satpy/__init__.py:32:1: F401 'satpy.version.__version__' imported but unused
satpy/__init__.py:33:1: F401 'satpy.dataset.Dataset' imported but unused
satpy/__init__.py:33:1: F401 'satpy.dataset.DATASET_KEYS' imported but unused
satpy/__init__.py:33:1: F401 'satpy.dataset.DatasetID' imported but unused
satpy/__init__.py:34:1: F401 'satpy.readers.DatasetDict' imported but unused
satpy/__init__.py:34:1: F401 'satpy.readers.find_files_and_readers' imported but unused
satpy/dataset.py:121:1: E305 expected 2 blank lines after class or function definition, found 1
satpy/scene.py:32:1: F401 'satpy.config.runtime_import' imported but unused
satpy/scene.py:279:9: F841 local variable 'unknowns' is assigned to but never used
satpy/utils.py:42:1: E722 do not use bare except'

@djhoese djhoese merged commit 3ce5081 into maint/0.8 Jun 15, 2018
@djhoese djhoese deleted the bugfix-DNC branch June 15, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants