Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scene not being copied properly during resampling #214

Merged
merged 5 commits into from Mar 7, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 7, 2018

This PR addresses the issues brought up in #208 as well as a couple refactors.

  1. Fix Scene wishlist being shared between a scene and the new scene generated during resampling.
  2. Fix Scene dependency tree being shared between scenes after resampling.
  3. Fix loading not being able to handle dependency tree nodes created by user's manually adding datasets to the Scene.
  4. Fix use of deprecated self.assertEquals in Scene tests.
  5. Rename _read_datasets and _read_composites in Scene since they require internal objects to be passed to them and should not be accessed by users.

@djhoese djhoese added the bug label Mar 7, 2018
@djhoese djhoese self-assigned this Mar 7, 2018
@djhoese djhoese requested a review from mraspaud March 7, 2018 21:02
satpy/scene.py Outdated
reader_name = node.data.get('reader_name')
if reader_name is None:
raise RuntimeError("Dependency tree has a corrupt node. "
"This shouldn't be possible.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write "This should be impossible" as a comment.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.4%) to 59.49% when pulling 7b08c06 on bugfix-scene-copy into 56d2b6a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 59.49% when pulling 82c12af on bugfix-scene-copy into 56d2b6a on develop.

@djhoese djhoese changed the title Bugfix scene copy Fix Scene not being copied properly during resampling Mar 7, 2018
@djhoese djhoese added the component:dep_tree Dependency tree and dataset loading label Mar 7, 2018
@djhoese djhoese added this to the v0.9 milestone Mar 7, 2018
@djhoese djhoese merged commit cebde2b into develop Mar 7, 2018
@djhoese djhoese deleted the bugfix-scene-copy branch March 7, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component:dep_tree Dependency tree and dataset loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants