Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TestYAMLFiles to pytest #2404

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 1, 2023

This should hopefully fix some leaking monkeypatch modifications. My theory based on the failures seen in the unstable/test environment is that this monkeypatch'd import was being used in other tests besides the one it was implemented in (tracebacks include the real_import name). It may not be the actual solution to the failures in the experimental environment, but it is a start.

CC @BENR0

  • Closes #xxxx
  • Tests added
  • Fully documented

This should hopefully fix some leaking monkeypatch modifications
@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Mar 1, 2023
@djhoese djhoese requested a review from mraspaud as a code owner March 1, 2023 19:08
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2404 (431032c) into main (16d3184) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
- Coverage   94.73%   94.73%   -0.01%     
==========================================
  Files         329      329              
  Lines       48739    48736       -3     
==========================================
- Hits        46171    46168       -3     
  Misses       2568     2568              
Flag Coverage Δ
behaviourtests 4.41% <0.00%> (+<0.01%) ⬆️
unittests 95.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/enhancement_tests/test_ahi.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_fy4_base.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_ghi_l1.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_msi_safe.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_msu_gsa_l1b.py 100.00% <100.00%> (ø)
...tpy/tests/reader_tests/test_oceancolorcci_l3_nc.py 100.00% <100.00%> (ø)
satpy/tests/test_readers.py 98.89% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Mar 1, 2023

Coverage Status

Coverage: 95.319% (-0.0003%) from 95.319% when pulling 431032c on djhoese:tests-leaking-imports into 16d3184 on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Mar 3, 2023

I thought I mentioned it here, but I guess I only commented on slack. The CI failure is caused by an incompatibility between holoviews and dev numpy. See:

numpy/numpy#23307

and:

holoviz/holoviews#5635

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the modernisation!

@mraspaud mraspaud added this to the v0.41.0 milestone Mar 6, 2023
@mraspaud mraspaud merged commit 06809fc into pytroll:main Mar 6, 2023
@djhoese djhoese deleted the tests-leaking-imports branch March 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants