-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing test dependencies and update dev environment documentation #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! Maybe one more approval from a maintainer and then we merge when the tests pass?
You marked this as a draft. What's left to do?
Codecov Report
@@ Coverage Diff @@
## main #2472 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 339 339
Lines 49369 49369
=======================================
Hits 46811 46811
Misses 2558 2558
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 4926992540Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
wanted to be on the safe side and mark it draft first :) |
any ideas what i can do for this PR to get the last test running? |
No this is expected at this moment in time. Holoviews is incompatible with unstable numpy and holoviews hasn't released a new version for a long time with the fix for the incompatibility. This is ready to merge. I was just hoping for one more person to check it over. If they don't in the next hour then I'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the missing dependecies to
test_requires
insetup.py
so that all the tests run. Also the recommeded python version in the docs is updated topython=3.11
.