Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test dependencies and update dev environment documentation #2472

Merged
merged 1 commit into from
May 10, 2023

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented May 9, 2023

This PR adds the missing dependecies to test_requires in setup.py so that all the tests run. Also the recommeded python version in the docs is updated to python=3.11.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Maybe one more approval from a maintainer and then we merge when the tests pass?

You marked this as a draft. What's left to do?

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2472 (62785b0) into main (2aac9e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2472   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files         339      339           
  Lines       49369    49369           
=======================================
  Hits        46811    46811           
  Misses       2558     2558           
Flag Coverage Δ
behaviourtests 4.42% <ø> (ø)
unittests 95.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@djhoese djhoese added bug documentation cleanup Code cleanup but otherwise no change in functionality labels May 9, 2023
@djhoese djhoese changed the title Add missing dependencies for all the tests to run. Add missing test dependencies and update dev environment documentation May 9, 2023
@coveralls
Copy link

coveralls commented May 9, 2023

Pull Request Test Coverage Report for Build 4926992540

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 95.044%

Totals Coverage Status
Change from base Build 4915888394: -0.3%
Covered Lines: 39486
Relevant Lines: 41545

💛 - Coveralls

@sjoro
Copy link
Collaborator Author

sjoro commented May 9, 2023

wanted to be on the safe side and mark it draft first :)

@sjoro sjoro marked this pull request as ready for review May 9, 2023 15:20
@sjoro sjoro requested a review from mraspaud as a code owner May 9, 2023 15:20
@sjoro
Copy link
Collaborator Author

sjoro commented May 10, 2023

any ideas what i can do for this PR to get the last test running?

@djhoese
Copy link
Member

djhoese commented May 10, 2023

No this is expected at this moment in time. Holoviews is incompatible with unstable numpy and holoviews hasn't released a new version for a long time with the fix for the incompatibility. This is ready to merge. I was just hoping for one more person to check it over. If they don't in the next hour then I'll merge it.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 8f9e574 into pytroll:main May 10, 2023
@sjoro sjoro deleted the fix-missing-dependencies branch May 11, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup Code cleanup but otherwise no change in functionality documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies in setup.py for running all the tests
4 participants