-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ABI L2 reader to produce reflectances as percentages #2607
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2607 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 354 354
Lines 51474 51487 +13
=======================================
+ Hits 48873 48886 +13
Misses 2601 2601
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pull Request Test Coverage Report for Build 6607378876
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm really not sure my "if" was the right thing here now. I'm only checking the units really, but plenty of L2 products have units of 1. I'll have to make another PR with something smarter. |
Sorry I didn't spot it. I'm not familiar with the product... |
No. No problem. Just pointing out that I realized this after I went to bed last night. I'll clean it up shortly (hopefully). |
As discussed on slack, this data handling has been broken for a long time (since creation?). Basically the CMIP Level 2 files are solar zenith correction versions of the L1b bands. Satpy expects reflectances to be 0 to ~100 (%), but in ABI files they are 0 to ~1. This PR fixes this.
CC @yufeizhu600
AUTHORS.md
if not there already