Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI L2 to only convert reflectances to percentages #2608

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 23, 2023

This is an add-on to #2607 where I realized after merging that the if statement (copied from the L1b reader) would be applied to any non-count data with units of "1". For L1b this is really only reflectances I think, but for L2 this could be many many other products. This PR changes this to be specifically calibration == "reflectance" which I think is safe enough for now.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2608 (bd43ad6) into main (d762d1c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2608   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         354      354           
  Lines       51487    51487           
=======================================
  Hits        48886    48886           
  Misses       2601     2601           
Flag Coverage Δ
behaviourtests 4.26% <0.00%> (ø)
unittests 95.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/readers/abi_l2_nc.py 96.22% <100.00%> (ø)

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank for the quick fix.

@mraspaud mraspaud added this to the v0.45.0 milestone Oct 23, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6612755225

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.515%

Totals Coverage Status
Change from base Build 6610863260: 0.0%
Covered Lines: 49009
Relevant Lines: 51310

💛 - Coveralls

@mraspaud mraspaud merged commit 0f339d1 into pytroll:main Oct 23, 2023
19 of 20 checks passed
@djhoese djhoese deleted the bugfix-abil2-refl-toomany branch October 23, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants