Add file pattern for CRRPh of NWC SAF GEO v2021 #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 356 356
Lines 51605 51605
=======================================
Hits 49134 49134
Misses 2471 2471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7017704049
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2021 version NWC SAF GEO software producess CRRPh ("convective rain rate from physical somethingorother") using file names like
S_NWC_CRRPh_MSG3_MSG-N-VISIR_20231128T051500Z.nc. The previous version (v2018) has the files named with a dash:S_NWC_CRR-Ph_MSG3_MSG-N-VISIR_20231128T051500Z.nc. This PR adds the new pattern.There's a similar change to
PC-Ph->PCPhbut we don't have that product currently in the config, and I'm not sure its yet supported.In addition one unrelated failing test assertion is adjusted for floating point handling.