Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in NWC SAF GEO v2021 data #2672

Closed
pnuu opened this issue Dec 11, 2023 · 1 comment · Fixed by #2673
Closed

Changes in NWC SAF GEO v2021 data #2672

pnuu opened this issue Dec 11, 2023 · 1 comment · Fixed by #2673
Assignees
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@pnuu
Copy link
Member

pnuu commented Dec 11, 2023

Feature Request

Is your feature request related to a problem? Please describe.
There are some changes in the files produced by the NWC SAF GEO v2021 compared to v2018. These are the ones I've noticed on the files I now use:

  • ASII-TF
    • asii_turb_trop_prob -> asiitf_prob
  • ASII-GW
    • asii_turb_wave_prob -> asiigw_wv_prob

Describe the solution you'd like
Make it so also the new files work.

Describe any changes to existing user workflow
The variable names will change from v2018 to v2021.

Additional context
The old variable names could be mapped to the new ones so that user would not need to change anything, but this would go against our "use the naming in the data" principle.

@pnuu pnuu added enhancement code enhancements, features, improvements component:readers labels Dec 11, 2023
@pnuu pnuu self-assigned this Dec 11, 2023
@pnuu
Copy link
Member Author

pnuu commented Dec 11, 2023

There is also this warning: Required file type 'nc_nwcsaf_crr-ph' not found or loaded for 'crrph_intensity' and the data are not read. This must've been missed in #2652 by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant