Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sun-zenith reducer defaults #2653

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

ameraner
Copy link
Member

This PR updates the Sun-zenith reducer default parameters to reduce the effect of the reduction and keep more data close to the terminator. See #2643 for the discussion.

@ameraner ameraner self-assigned this Nov 28, 2023
@ameraner ameraner added enhancement code enhancements, features, improvements component:enhancements labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed220be) 95.21% compared to head (4dd1920) 95.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2653   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         356      356           
  Lines       51605    51605           
=======================================
  Hits        49134    49134           
  Misses       2471     2471           
Flag Coverage Δ
behaviourtests 4.22% <50.00%> (ø)
unittests 95.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7021329657

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.784%

Totals Coverage Status
Change from base Build 7019457197: 0.0%
Covered Lines: 49260
Relevant Lines: 51428

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit d21861c into pytroll:main Nov 28, 2023
18 of 19 checks passed
@ameraner ameraner deleted the update_sunz_reducer branch April 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SunZenithReducer defaults make True Color FCI imagery too dark at high solar zenith angles
3 participants