Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SunZenithReducer defaults make True Color FCI imagery too dark at high solar zenith angles #2643

Closed
ameraner opened this issue Nov 21, 2023 · 5 comments · Fixed by #2653
Closed
Assignees
Labels
component:enhancements enhancement code enhancements, features, improvements

Comments

@ameraner
Copy link
Member

The SunZenithReducer modifier has been implemented in #2556 to have a nice, smooth and artefact-free transition into nighttime when Rayleigh correction is applied to VIS-based composites (see PR for details).

As reported by Cris (MetOffice) in the mailing list, the current defaults for the reducer are making imagery at high solar angles too dark.
How come? The defaults were defined for the FCI First Image publications, which was taken close to the equinox (rather uniform illumination), and with the goal to produce imagery with very smooth day/night transitions. Now that we're entering the first winter season on the North hemisphere, with permanently high solar zenith angles, the issue is emerging.

I've done some experiments, trying to optimise the tradeoffs between (in descending order of importance):

  • keeping as much data as possible close to the terminator, with usable brightness
  • avoiding the reddish artefacts
  • avoiding the limb-glow caused by the sunzen correction, particularly the "peak" line at the terminator
  • keeping a natural transition appearance

What I came up with was increasing the limit angle (where the reduction starts to kick-in) from 55° to 80°, and decrease the strength (defining the shape of the reduction function, see plot here ) from 1.5 to 1.3.

A few examples from a few days ago (20231117)
Northern Europe

Settings 8UTC 12UTC
No reduction ( reddish artefacts + glow) 8noreduce noreduce
55° limit, 1.5 strength (current main - no artefacts, no glow, but too dark too early) 855 55
80° limit, 1.3 strength (proposal) 8n80-1p3 n80-1p3

Full-disc

Settings 8UTC 12UTC
No reduction ( reddish artefacts + glow) 8fnoreduce fnoreduce
55° limit, 1.5 strength (current main - no artefacts, no glow, but too dark too early) 8f551p5 f551p5
80° limit, 1.3 strength (proposal) 8f80-1p3 f80-1p3

First Image (for comparison for an equinox scene)

Settings
No reduction firstimagenocorr
55° limit, 1.5 strength - Current main, very similar to published version firstimageoriginal
80° limit, 1.3 strength (proposal) firstimagef80-1p3

We (with @strandgren ) think the new setting satisfies well the tradeoff points above, let me know what you think!

In any case, I would propose to add in the FCI composites the version without reduction, so that it's easily accessible for users that need to keep as much data as possible, at the cost of introducing some artefacts. What should the name be? true_color_nosunzreduction?


PS: if someone wants to experiment with the parameters, the full definition of the modifier looks like this:

sunz_reduced:
    modifier: !!python/name:modifiers.geometry.SunZenithReducer
    correction_limit: 80
    strength: 1.3
    max_sza: 90
    optional_prerequisites:
      - solar_zenith_angle

(to be modified either in local custom composite configuration, or here)

@ameraner ameraner added enhancement code enhancements, features, improvements component:enhancements labels Nov 21, 2023
@ameraner ameraner self-assigned this Nov 21, 2023
@mraspaud
Copy link
Member

Very nice work summing this up with examples!
I agree the proposal looks like a very good compromise of the different requirements. I also agree a version with no reduction is good to have. How about true_color_fully_normalizedfor the name?

@adybbroe
Copy link
Contributor

Yes, agree with Martin, good work and very nicely compiled and explained. And yes always good to also have the option to go back to "no reduction".

@ameraner
Copy link
Member Author

Thanks, glad you like it :)
mmm tbh I'm not convinced by the fully_normalized, since it sounds a bit "absolute" and there are probably more normalizations one could apply that are not included here. Along that line, maybe fully_sunzencorrected could work?

@mraspaud
Copy link
Member

works for me :)

@ameraner
Copy link
Member Author

ameraner commented Dec 4, 2023

A preview how the new setup will look like on EUMETView (today 09:40 UTC):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants