Fix missing radiance units in eps l1b #2655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 369 369
Lines 52040 52049 +9
=======================================
+ Hits 49591 49600 +9
Misses 2449 2449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -144,7 +144,8 @@ class EPSAVHRRFile(BaseFileHandler): | |||
| sensors = {"AVHR": "avhrr-3"} | |||
|
|
|||
| units = {"reflectance": "%", | |||
| "brightness_temperature": "K"} | |||
| "brightness_temperature": "K", | |||
There was a problem hiding this comment.
Just because I feel like being a pain today...if this had ended with a comma and the } was on its own line, it wouldn't have been part of the diff. The history...the git history!!! 😱
There was a problem hiding this comment.
But then again, that would require from us to read one more line to understand the dictionary is closed here. Also github could be smarter and just show the actual diffing chars, like eg delta does to make reviews easier.
https://github.com/dandavison/delta
There was a problem hiding this comment.
Ah yes syntax diffs are nice. In the "read one more line" argument, why do you need to know the dictionary is closed (ignoring that it is just one more line)? You are going to keep reading the code to see where the dictionary is used anyway.
There was a problem hiding this comment.
black would reformat it like that.
There was a problem hiding this comment.
Yes, that's why we don't have it 😀
There was a problem hiding this comment.
Lol yeah sorry, there is a much longer history to this discussion that isn't obvious from my single comment here.
This PR fixes a bug preventing reading radiance from avhrr eps l1b data.