Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix vgac reader #2754

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Bugfix vgac reader #2754

merged 2 commits into from
Mar 8, 2024

Conversation

ninahakansson
Copy link
Contributor

Fix a bug I intruded when writing unit test for the time var in the vgac reader. The time_proj0 is a scalar in the files, and now also in the unittest case.

  • Tests added

Nina.Hakansson added 2 commits March 8, 2024 14:14
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (7e336ee) to head (85d9117).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2754   +/-   ##
=======================================
  Coverage   95.93%   95.94%           
=======================================
  Files         375      375           
  Lines       53223    53293   +70     
=======================================
+ Hits        51058    51130   +72     
+ Misses       2165     2163    -2     
Flag Coverage Δ
behaviourtests 4.12% <0.00%> (-0.01%) ⬇️
unittests 96.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8204057910

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.02%

Totals Coverage Status
Change from base Build 8200761354: 0.0%
Covered Lines: 51002
Relevant Lines: 53116

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit f6b1096 into pytroll:main Mar 8, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants