-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues in unstable CI #2784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2784 +/- ##
========================================
Coverage 95.93% 95.94%
========================================
Files 377 379 +2
Lines 53559 53673 +114
========================================
+ Hits 51381 51494 +113
- Misses 2178 2179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8756273146Details
💛 - Coveralls |
@mraspaud Ok I've got CI working in unstable as far as numpy 2 goes and what we have control over. The remaining things are:
I think this is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cftime's master branch should support numpy 2 now, but from what I could tell our CI still wasn't working. My best guess is the conda-installed version is getting used before the pip one. This PR first removes the conda installed one in unstable CI before installing from source.
AUTHORS.md
if not there already