Fix lookup table enhancement for multi-band datasets #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
reviewed
Jul 3, 2018
| @@ -78,10 +78,10 @@ def apply_enhancement(data, func, exclude=None, separate=False, | |||
| if pass_dask: | |||
| dims = band_data.dims | |||
| coords = band_data.coords | |||
| d_arr = func(band_data.data) | |||
| d_arr = func(band_data.data, index=idx) | |||
There was a problem hiding this comment.
Doesn't adding an index keyword argument break other enhancement functions that don't expect it?
There was a problem hiding this comment.
I tried to fix those I could find at least
There was a problem hiding this comment.
ie I couldn't find any more calls to apply_enhancement that would require a change
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 69.18% 69.17% -0.02%
==========================================
Files 123 123
Lines 15691 15696 +5
==========================================
+ Hits 10856 10857 +1
- Misses 4835 4839 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lookup table enhancement for multi-band datasets
git diff origin/master **/*py | flake8 --diff