Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask calibrated GOES HRIT data #380

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Mask calibrated GOES HRIT data #380

merged 1 commit into from
Aug 15, 2018

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Aug 1, 2018

This PR masks data when loading calibrated GOES HRIT data.

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage decreased (-0.002%) to 69.083% when pulling 7f02be6 on bugfix-hrit_goes-masking into ade4f95 on master.

@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #380 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   69.08%   69.08%   -0.01%     
==========================================
  Files         123      123              
  Lines       15724    15726       +2     
==========================================
+ Hits        10863    10864       +1     
- Misses       4861     4862       +1
Impacted Files Coverage Δ
satpy/readers/hrit_goes.py 50.67% <50%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade4f95...7f02be6. Read the comment docs.

@pnuu
Copy link
Member Author

pnuu commented Aug 6, 2018

There seems to be still something that causes IR data to be masked on areas where there's no VIS data.

@djhoese
Copy link
Member

djhoese commented Aug 14, 2018

@pnuu Are you still having issues with this? Should I wait to merge this?

@pnuu
Copy link
Member Author

pnuu commented Aug 15, 2018

The problem I mentioned is actually the one in #383, just forgot to reference that issue. The masking is otherwise OK with this PR.

@djhoese
Copy link
Member

djhoese commented Aug 15, 2018

So I can merge this?

@pnuu
Copy link
Member Author

pnuu commented Aug 15, 2018

Yes, go ahead.

@djhoese djhoese merged commit eb48ec0 into master Aug 15, 2018
@djhoese djhoese deleted the bugfix-hrit_goes-masking branch August 15, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants