-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed that save_dataset does not propagate fill_value #423
Conversation
…ed_image. Further does not get_enhanced_image propagate fill_value into add_overlay and add_decorate. Those in turn does not propagate fill_value into pil_image.
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 71.94% 71.94%
=======================================
Files 128 127 -1
Lines 16884 16884
=======================================
Hits 12147 12147
Misses 4737 4737
Continue to review full report at Codecov.
|
So I've looked at this more and it makes sense that
So the above situation makes sense for why this is happening and producing undesired results. I have no issue with this solution. I do have an issue with the performance of the functions as implemented. IMO the multiple calls to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo
satpy/writers/__init__.py
Outdated
|
||
if decorate is not None: | ||
add_decorate(img, **decorate) | ||
add_decorate(img, fille_value=fill_value, **decorate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fill_value
versus fille_value
.
Thanks Regarding the pil_image; yes it is a bad solution if both are invoked. But at the time this was implemented I could not see another solution. I'm happy to discuss this at some point in time. |
Best I could think of is pass the PIL image to these functions. It makes them harder to use outside of the |
Fixed that save_dataset does not propagate fill_value into get_enhanced_image. Further does not get_enhanced_image propagate fill_value into add_overlay and add_decorate. Those in turn does not propagate fill_value into pil_image.