Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace areas.def with areas.yaml #442

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Replace areas.def with areas.yaml #442

merged 1 commit into from
Oct 5, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 5, 2018

Replace areas.def with areas.yaml, as yaml is the new format for area definitons.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.078% when pulling 1012fec on feature-areas-yaml into 4e1e149 on master.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         134      134           
  Lines       17662    17662           
=======================================
  Hits        12907    12907           
  Misses       4755     4755

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1e149...1012fec. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to modify MANIFEST.in?

@mraspaud
Copy link
Member Author

mraspaud commented Oct 5, 2018

doesn't seem so, but thanks for the reminder, I hadn't thought of that.

@mraspaud mraspaud merged commit eb1fe79 into master Oct 5, 2018
@mraspaud mraspaud deleted the feature-areas-yaml branch October 5, 2018 13:07
@djhoese djhoese added the enhancement code enhancements, features, improvements label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants