New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two luminance sharpening compositors #503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 74.48% 74.56% +0.08%
==========================================
Files 136 136
Lines 18328 18399 +71
==========================================
+ Hits 13651 13720 +69
- Misses 4677 4679 +2
Continue to review full report at Codecov.
|
Still need to add tests, and start using the luminance conversion formulae from |
Looks good, but I would rather reuse the functions from trollimage (which is a dependency of satpy) instead of copying them to satpy |
Agree with not copying functions that are supposed to exist in trollimage. FYI @pnuu there is this PR by @katherinekolman addressing the dask-ification of the convert method: pytroll/trollimage#28 I was thinking that she didn't need to implement the YUV/YCbCr conversions right now and would merge what she has since we don't need those other conversions (@mraspaud thoughts?). @pnuu You could add on to what she has started. |
Yes, I agree that eventually the conversions should go via the |
This PR adds two compositors that can be used to apply luminance from a VIS channel to RGB composites.
LuminanceSharpeninCompositor
: replaces the luminance via RGB -> YCbCr -> RGB conversionSandwichCompositor
: multiplies the RGB channels with the reflectance (scaled to [0.0, 1.0])Example composites for SEVIRI included are:
vis_sharpened_ir
andir_sandwich
git diff origin/master -- "*py" | flake8 --diff