-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convert method of XRImage #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
While the Image object implements the |
I'd also like the convertion to return a new image. In this way it would be possible to easily use the same object to get several different colorspaces for what ever use. E.g. to get (in future) |
Close #21 |
The colorize method needed to be updated to run on the numpy array that was passed, not the buffer of the numpy array.
I tested the updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job. There are a couple things I'd like changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starts to shape up nicely!
git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)