Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhancement for VIIRS flood reader #532

Merged
merged 10 commits into from May 9, 2019

Conversation

katherinekolman
Copy link

@katherinekolman katherinekolman commented Dec 3, 2018

This adds an enhancement for the VIIRS EDR Flood reader.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage increased (+0.04%) to 81.554% when pulling 70b64da on katherinekolman:viirs_edr_flood_reader into 81b3334 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #532 into master will increase coverage by 0.03%.
The diff coverage is 94.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   81.51%   81.55%   +0.03%     
==========================================
  Files         154      157       +3     
  Lines       22570    22623      +53     
==========================================
+ Hits        18398    18450      +52     
- Misses       4172     4173       +1
Impacted Files Coverage Δ
satpy/tests/enhancement_tests/test_enhancements.py 98.55% <ø> (ø)
satpy/enhancements/viirs.py 100% <100%> (ø)
satpy/tests/enhancement_tests/test_viirs.py 100% <100%> (ø)
satpy/tests/__init__.py 93.1% <100%> (ø) ⬆️
satpy/readers/viirs_edr_flood.py 90.24% <50%> (ø) ⬆️
satpy/tests/enhancement_tests/__init__.py 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b3334...70b64da. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented May 9, 2019

@mraspaud @pnuu I accidentally requested your review on this and github won't let me remove it. I meant to do it on #580.

@djhoese djhoese merged commit a1d7bbe into pytroll:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants