Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colormaps to be saved with geotiff writer #580

Merged
merged 7 commits into from May 9, 2019

Conversation

katherinekolman
Copy link

This makes it so users can keep the palettized version of the image and apply a colormap to it. There's a related pull request in trollimage.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@coveralls
Copy link

coveralls commented Jan 17, 2019

Coverage Status

Coverage increased (+0.2%) to 81.575% when pulling 77c3d14 on katherinekolman:colormap into d13b670 on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #580 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   81.41%   81.57%   +0.16%     
==========================================
  Files         154      154              
  Lines       22447    22583     +136     
==========================================
+ Hits        18276    18423     +147     
+ Misses       4171     4160      -11
Impacted Files Coverage Δ
satpy/writers/geotiff.py 43.54% <100%> (+1.88%) ⬆️
satpy/tests/writer_tests/test_geotiff.py 93.5% <100%> (+0.85%) ⬆️
satpy/enhancements/__init__.py 85.33% <100%> (+8%) ⬆️
.../tests/reader_tests/test_viirs_edr_active_fires.py 97.16% <0%> (+0.98%) ⬆️
satpy/readers/viirs_edr_active_fires.py 93.61% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13b670...77c3d14. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Mar 14, 2019

@mraspaud if I fix the conflict in this, do you think we could/should merge this? Or should we wait for me or Kat to add documentation on how it should be used?

@mraspaud
Copy link
Member

Just some documentation in the docstring would be enough for me

@mraspaud mraspaud added component:writers enhancement code enhancements, features, improvements labels Apr 10, 2019
@djhoese djhoese requested review from pnuu and removed request for djhoese May 9, 2019 02:30
@djhoese djhoese changed the title Allow colormaps to be passed in Allow colormaps to be saved with geotiff writer May 9, 2019
@djhoese djhoese merged commit 8c837de into pytroll:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants