Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ratio sharpening compositors when the ratio is negative #548

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 13, 2018

This fixes a logic bug and cleans up the code for the RatioSharpenedRGB compositor class. This fixes the bright cyan pixels on the edges of clouds in things like the ABI true color RGB. I still need to add tests.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@djhoese djhoese added this to the v0.11 milestone Dec 13, 2018
@djhoese djhoese self-assigned this Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@12298a9). Click here to learn what that means.
The diff coverage is 99%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #548   +/-   ##
=========================================
  Coverage          ?   75.97%           
=========================================
  Files             ?      136           
  Lines             ?    18807           
  Branches          ?        0           
=========================================
  Hits              ?    14288           
  Misses            ?     4519           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/tests/compositor_tests/__init__.py 98.95% <100%> (ø)
satpy/composites/__init__.py 59.43% <96.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12298a9...9530edc. Read the comment docs.

@djhoese djhoese changed the title [WIP] Fix ratio sharpening when the ratio is negative Fix ratio sharpening compositors when the ratio is negative Dec 14, 2018
@djhoese djhoese merged commit e454b44 into pytroll:master Dec 14, 2018
@djhoese djhoese deleted the bugfix-ratio-sharpen3 branch December 14, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant