Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start_time type in seviri_l1b_nc reader #588

Merged
merged 2 commits into from Jan 24, 2019

Conversation

BENR0
Copy link
Collaborator

@BENR0 BENR0 commented Jan 23, 2019

Trying to write out geotiff files from data loaded with seviri_l1b_nc
reader gives Error because the reader sets start_time and end_time as
string instead of datetime. This commit fixes this error.

Trying to write out geotiff files from data loaded with seviri_l1b_nc
reader gives Error because the reader sets start_time and end_time as
string instead of datetime. This commit fixes this error.
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you also remove the _time_format function that seems to not be used anymore?

@BENR0
Copy link
Collaborator Author

BENR0 commented Jan 23, 2019

Removed the function.
Something else: I haven't checked if it already is, but if not maybe the documentation on writing own readers should mention that start and end_time attributes should be of type datetime and not string in order to be compatible with the writers?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 77.449% when pulling 8d1a14c on BENR0:fix_start_time_seviri_l1b_nc_reader into 630cc37 on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #588 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   77.44%   77.44%   +<.01%     
==========================================
  Files         136      136              
  Lines       19153    19152       -1     
==========================================
  Hits        14833    14833              
+ Misses       4320     4319       -1
Impacted Files Coverage Δ
satpy/readers/seviri_l1b_nc.py 17.82% <0%> (-0.63%) ⬇️
satpy/multiscene.py 79.12% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630cc37...8d1a14c. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Jan 23, 2019

@sjoro @ColinDuff I assume one of you worked on this reader? Are these changes ok with you?

@djhoese djhoese added this to the v0.12 milestone Jan 23, 2019
@sjoro
Copy link
Collaborator

sjoro commented Jan 24, 2019

looks good to me!

@ColinDuff
Copy link
Contributor

fine by me

@djhoese djhoese merged commit 73c1600 into pytroll:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants