-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix start_time type in seviri_l1b_nc reader #588
Fix start_time type in seviri_l1b_nc reader #588
Conversation
Trying to write out geotiff files from data loaded with seviri_l1b_nc reader gives Error because the reader sets start_time and end_time as string instead of datetime. This commit fixes this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Could you also remove the _time_format
function that seems to not be used anymore?
Removed the function. |
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 77.44% 77.44% +<.01%
==========================================
Files 136 136
Lines 19153 19152 -1
==========================================
Hits 14833 14833
+ Misses 4320 4319 -1
Continue to review full report at Codecov.
|
@sjoro @ColinDuff I assume one of you worked on this reader? Are these changes ok with you? |
looks good to me! |
fine by me |
Trying to write out geotiff files from data loaded with seviri_l1b_nc
reader gives Error because the reader sets start_time and end_time as
string instead of datetime. This commit fixes this error.