-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'crop' and 'save_datasets' to MultiScene #613
Merged
djhoese
merged 14 commits into
pytroll:master
from
djhoese:feature-mscn-crop-save-datasets
Feb 13, 2019
Merged
Add 'crop' and 'save_datasets' to MultiScene #613
djhoese
merged 14 commits into
pytroll:master
from
djhoese:feature-mscn-crop-save-datasets
Feb 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 78.13% 78.33% +0.19%
==========================================
Files 136 136
Lines 19615 19714 +99
==========================================
+ Hits 15327 15442 +115
+ Misses 4288 4272 -16
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 'crop' and 'save_datasets' method to the
MultiScene
object. It also cleans up some of the dask distributed usage from a previous PR. This adds the functionality to use dask distributed in save_datasets for the MultiScene as well which can improve processing time.The biggest possible cause of issues from this PR is the work I had to do is to fix the serialization of multiple readers and other parts of satpy. Dask distributed does not like
map_blocks
ordelayed
functions to be internal functions because they can't be serialized. This should be fixed in all of satpy now.I still need to write tests.
git diff origin/master -- "*py" | flake8 --diff