Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing-mode and disposition-mode to the avhrr-l1b-eps file name #638

Conversation

TAlonglong
Copy link
Collaborator

The avhrr-l1b-eps file name is hardcoded with processing-mode to N and disposition-mode to O

During the commisioning of Metop-C at least the disposition-mode needs to added.

According to documentation: http://www.eumetsat.int/website/wcm/idc/idcplg?IdcService=GET_FILE&dDocName=PDF_AVHRR_L1B_PRODUCT_GUIDE&RevisionSelectionMethod=LatestReleased&Rendition=Web

Enumeration DISPOSITION_MODE
Value Name
T Testing
O Operational
C Commissioning

Enumeration PROCESSING_MODE
Value Name Description
N Nominal NRT processing
B Backlog Processing
R Reprocessing
V Validation

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 78.282% when pulling 5d18c7f on TAlonglong:feature-handle-avhrr-l1b-eps-disposition-mode into ccacdf4 on pytroll:master.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #638   +/-   ##
======================================
  Coverage    78.3%   78.3%           
======================================
  Files         136     136           
  Lines       19735   19735           
======================================
  Hits        15453   15453           
  Misses       4282    4282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccacdf4...5d18c7f. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added bug component:readers enhancement code enhancements, features, improvements and removed bug labels Mar 5, 2019
@mraspaud mraspaud added this to the v0.13 milestone Mar 5, 2019
@mraspaud mraspaud merged commit 0cefc09 into pytroll:master Mar 5, 2019
@mraspaud
Copy link
Member

mraspaud commented Mar 5, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants