Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml load to be compatible with pyyaml 5.1 #655

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 14, 2019

Pyyaml 5.1 deprecated the use of unsafe loading as default, making satpy config loading shaky. This PR restores the expected behaviour in satpy

Here are some explanations about the pyyaml change:
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@mraspaud mraspaud self-assigned this Mar 14, 2019
@mraspaud mraspaud added the bug label Mar 14, 2019
@mraspaud mraspaud added this to the v0.13 milestone Mar 14, 2019
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #655 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage    78.4%   78.39%   -0.02%     
==========================================
  Files         138      138              
  Lines       19990    20013      +23     
==========================================
+ Hits        15673    15689      +16     
- Misses       4317     4324       +7
Impacted Files Coverage Δ
satpy/config.py 47.91% <42.85%> (+0.09%) ⬆️
satpy/plugin_base.py 88% <60%> (-7.24%) ⬇️
satpy/composites/__init__.py 65.55% <66.66%> (-0.09%) ⬇️
satpy/readers/__init__.py 94.54% <66.66%> (+0.66%) ⬆️
satpy/readers/yaml_reader.py 92.26% <71.42%> (-0.35%) ⬇️
satpy/writers/__init__.py 85.82% <81.81%> (-0.37%) ⬇️
satpy/scene.py 88.95% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee02de0...0fc351c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 78.394% when pulling 0fc351c on mraspaud:fix-yaml-load into ee02de0 on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 78.394% when pulling 0fc351c on mraspaud:fix-yaml-load into ee02de0 on pytroll:master.

@mraspaud mraspaud merged commit fb39c41 into pytroll:master Mar 14, 2019
@mraspaud mraspaud deleted the fix-yaml-load branch March 14, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants