Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiScene save_animation when distributed isn't installed #677

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 26, 2019

If distributed is not installed and the user doesn't explicitly ask for client=False then it still tried to use distributed and would fail. This fixes it so the client is not used if distributed is not installed.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label Mar 26, 2019
@djhoese djhoese self-assigned this Mar 26, 2019
@djhoese djhoese added this to the v0.14 milestone Mar 26, 2019
satpy/tests/test_multiscene.py Outdated Show resolved Hide resolved
satpy/tests/test_multiscene.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage increased (+0.07%) to 78.732% when pulling e31dfc3 on djhoese:bugfix-multiscene-client into 0e5236f on pytroll:master.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #677 into master will increase coverage by 0.75%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   78.66%   79.41%   +0.75%     
==========================================
  Files         138      138              
  Lines       20357    21048     +691     
==========================================
+ Hits        16013    16716     +703     
+ Misses       4344     4332      -12
Impacted Files Coverage Δ
satpy/tests/test_multiscene.py 97.84% <100%> (+0.36%) ⬆️
satpy/multiscene.py 89.13% <77.77%> (+2.04%) ⬆️
satpy/tests/test_scene.py 99.43% <0%> (-0.05%) ⬇️
satpy/readers/__init__.py 95.65% <0%> (+1.1%) ⬆️
satpy/scene.py 93.18% <0%> (+3.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5236f...e31dfc3. Read the comment docs.

@djhoese
Copy link
Member Author

djhoese commented Mar 26, 2019

It was also brought up by @ColinDuff that imageio>2.5.0 may not work on all platforms or in all situations. This will need more investigation but downgrading for now is a good enough solution. There are no explicit tests in satpy that actually call in to imageio (we mock it).

@ColinDuff would you mind filing an issue with the error messages that you were getting (that is, the errors after passing client=False)?

@djhoese djhoese merged commit bb6aa6b into pytroll:master Mar 26, 2019
@djhoese djhoese deleted the bugfix-multiscene-client branch March 26, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants