-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of colorbar #839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=========================================
Coverage ? 86.77%
=========================================
Files ? 179
Lines ? 27305
Branches ? 0
=========================================
Hits ? 23694
Misses ? 3611
Partials ? 0 Continue to review full report at Codecov.
|
@zxdawn This still needs a test, right? Or does this not work for you? |
@djhoese I remember it works when using it alone. Will test again after my field-work. |
Finally, I tested this and here's the example and result: Script
ResultIssues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there any test you could add ? For example in this class:
satpy/satpy/tests/test_writers.py
Line 547 in 8237e1b
class TestOverlays(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for finishing this up.
Add
add_scale
(plotting colorbar) toadd_decorate
.