add support for meteo file in OLCI L1B reader #962
Conversation
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 87.37% 87.33% -0.04%
==========================================
Files 188 188
Lines 28624 28664 +40
==========================================
+ Hits 25009 25035 +26
- Misses 3615 3629 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Wow, thanks a lots for a very nice PR, taking the time to factorize the low res operations into a class!
I have a few comments as the coverage went down a bit. Also, codefactor complains about a couple trailing whitspaces. Could you have a look at these ? Appart from that, it looks good to me!
| elif key.name in self.cache: | ||
| values = self.cache[key.name] | ||
| else: | ||
| values = self.nc[key.name] |
There was a problem hiding this comment.
Could you test these two cases also ?
satpy/readers/olci_nc.py
Outdated
| @property | ||
| def start_time(self): | ||
| """Start the file handler.""" | ||
| return self._start_time | ||
|
|
||
| @property | ||
| def end_time(self): | ||
| """End the file handler.""" | ||
| return self._end_time |
There was a problem hiding this comment.
Would be nice to test these two.
|
@ghislainp will you have time to do the last fixes in the near future ? |
mraspaud
added
component:readers
enhancement
OLCI L1B product ships with a meteo ancillary data file. It is now read by the L1B reader and makes available 4 new datasets (humidity, sea_level_pressure, total_columnar_water_vapour and total_ozone) useful for atmospheric correction.
flake8 satpyAUTHORS.mdif not there already