Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CircleCI #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

honzajavorek
Copy link
Member

Currently Elsa is hardcoded for Travis CI. This is my attempt to bring support for CircleCI. I didn't test it - it's my best guess and I made it editing a file here using GitHub's pencil feature 馃檧

See https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables for a reference and https://circleci.com/gh/pyvec/pyvec.org/15#build-parameters/containers/0 (Spin Up Environment) for examples:

  BASH_ENV=/tmp/.bash_env-5d614082be728d64db773f33-0-build
  CI=true
  CIRCLECI=true
  CIRCLE_BRANCH=honzajavorek/members
  CIRCLE_BUILD_NUM=15
  CIRCLE_BUILD_URL=https://circleci.com/gh/pyvec/pyvec.org/15
  CIRCLE_COMPARE_URL=
  CIRCLE_JOB=build
  CIRCLE_NODE_INDEX=0
  CIRCLE_NODE_TOTAL=1
  CIRCLE_PREVIOUS_BUILD_NUM=14
  CIRCLE_PROJECT_REPONAME=pyvec.org
  CIRCLE_PROJECT_USERNAME=pyvec
  CIRCLE_PULL_REQUEST=https://github.com/pyvec/pyvec.org/pull/85
  CIRCLE_PULL_REQUESTS=https://github.com/pyvec/pyvec.org/pull/85
  CIRCLE_REPOSITORY_URL=git@github.com:pyvec/pyvec.org.git
  CIRCLE_SHA1=f6e04550035d3f904014689ee8f1541346b5feaf
  CIRCLE_SHELL_ENV=/tmp/.bash_env-5d614082be728d64db773f33-0-build
  CIRCLE_STAGE=build
  CIRCLE_USERNAME=honzajavorek
  CIRCLE_WORKFLOW_ID=e8affa4d-f267-4930-b339-af510fc8f849
  CIRCLE_WORKFLOW_JOB_ID=ce6ad044-09a4-4d4e-8423-ce085a50be0b
  CIRCLE_WORKFLOW_UPSTREAM_JOB_IDS=
  CIRCLE_WORKFLOW_WORKSPACE_ID=e8affa4d-f267-4930-b339-af510fc8f849
  CIRCLE_WORKING_DIRECTORY=~/repo
  CI_PULL_REQUEST=https://github.com/pyvec/pyvec.org/pull/85
  CI_PULL_REQUESTS=https://github.com/pyvec/pyvec.org/pull/85

See https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables for a reference and https://circleci.com/gh/pyvec/pyvec.org/15#build-parameters/containers/0 (Spin Up Environment) for examples:

  BASH_ENV=/tmp/.bash_env-5d614082be728d64db773f33-0-build
  CI=true
  CIRCLECI=true
  CIRCLE_BRANCH=honzajavorek/members
  CIRCLE_BUILD_NUM=15
  CIRCLE_BUILD_URL=https://circleci.com/gh/pyvec/pyvec.org/15
  CIRCLE_COMPARE_URL=
  CIRCLE_JOB=build
  CIRCLE_NODE_INDEX=0
  CIRCLE_NODE_TOTAL=1
  CIRCLE_PREVIOUS_BUILD_NUM=14
  CIRCLE_PROJECT_REPONAME=pyvec.org
  CIRCLE_PROJECT_USERNAME=pyvec
  CIRCLE_PULL_REQUEST=pyvec/pyvec.org#85
  CIRCLE_PULL_REQUESTS=pyvec/pyvec.org#85
  CIRCLE_REPOSITORY_URL=git@github.com:pyvec/pyvec.org.git
  CIRCLE_SHA1=f6e04550035d3f904014689ee8f1541346b5feaf
  CIRCLE_SHELL_ENV=/tmp/.bash_env-5d614082be728d64db773f33-0-build
  CIRCLE_STAGE=build
  CIRCLE_USERNAME=honzajavorek
  CIRCLE_WORKFLOW_ID=e8affa4d-f267-4930-b339-af510fc8f849
  CIRCLE_WORKFLOW_JOB_ID=ce6ad044-09a4-4d4e-8423-ce085a50be0b
  CIRCLE_WORKFLOW_UPSTREAM_JOB_IDS=
  CIRCLE_WORKFLOW_WORKSPACE_ID=e8affa4d-f267-4930-b339-af510fc8f849
  CIRCLE_WORKING_DIRECTORY=~/repo
  CI_PULL_REQUEST=pyvec/pyvec.org#85
  CI_PULL_REQUESTS=pyvec/pyvec.org#85
honzajavorek added a commit to pyvec/pyvec.org that referenced this pull request Aug 26, 2019
@honzajavorek
Copy link
Member Author

I probably won't be able to continue working on this one, but I knew I can provide more than to file an issue tonight, so I opened this. pyvec.org deployment seems unblocked by pyvec/pyvec.org@c9cf302 馃憤

elsa/_deployment.py Outdated Show resolved Hide resolved
Co-Authored-By: Miro Hron膷ok <miro@hroncok.cz>
@hroncok hroncok self-assigned this Aug 26, 2019
@hroncok
Copy link
Member

hroncok commented Aug 26, 2019

I liek the change in general. The CI failed here for style issues, easier to fix them locally than trying to do it via the web Interface :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants