Use more of the available screen #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only one macro is used for all entry renderings but speakers and events can be hidden depending on the context. This also gets rid of an extra padding around lists.
|
Anybody want to review this? Otherwise I'd merge it some time tomorrow 😃 |
|
It looks really nice! |
|
@lgh2 Thank you :) Turns out there was still a bug in there with the 3-col rendering for devices like the iPad. I'm currently in the process of patching that 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we hard-locked the content width at 730px. Especially on the event listing pages this left far too much white-space around the content.
This change resets the available width to bootstrap's default value and in most cases puts at least 2 (max. 4) videos per row on the screen.
Here are a handful of screenshots in various resolutions. This has so far been tested on the latest version of Safari, Firefox, Chrome, and Safari on iOS.
I'm not yet happy with big chunks of the markup. There isn't all that much I can do about that without working around bootstrap, which in turn would make it harder for new contributors. For that reason I've opted to leave those sections alone for now :)