Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

unable to get fullscreen for videos #284

Open
codersquid opened this issue Apr 17, 2015 · 4 comments
Open

unable to get fullscreen for videos #284

codersquid opened this issue Apr 17, 2015 · 4 comments

Comments

@codersquid
Copy link
Contributor

The full screen control might be hidden by the amara stuff.

@codersquid
Copy link
Contributor Author

bjonnh investigated this and reports back,

looks like the fullscreen mode is disabled by amara because they are not able to display captions when it is. I tried reactivating it in the css. when you fullscreen, it fullscreens in the iframe.

@codersquid
Copy link
Contributor Author

I've not looked at how amara works yet. I wonder if we could/should have a toggle for it.

@willkg
Copy link
Member

willkg commented May 4, 2015

Khan Academy used to use Amara for subtitles, but it appears they don't anymore and instead rely on the YouTube subtitling system. If someone knows that they still use Amara, please let me know where to see it.

Anyhow, a while back, Khan Academy would show the video on the web page and there was a button you'd press to enable subtitles. Clicking that button would do some DOM manipulation to re-load the video in the Amara widget.

If we did something similar, then the video wouldn't be in an iframe and we'd be able to fullscreen it. If you clicked on the subtitles button, then it'd do some DOM manipulation and you'd have whatever you had with the Amara widget.

I think that's the only effective option we have.

@codersquid
Copy link
Contributor Author

btw, bjonnh mentioned that, now we allow users to login, another thing we could do is allow people to set preferences for toggling amara.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants