-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit button causes crash #186
Comments
I think fa66ef4 should have fixed this |
Could you install pip install -U git+git://github.com/vtkiorg/vtki@master |
I'll try that later today. |
After pip installing from master I still get errors although they are a bit different:
Also, when I close the interactive window opened by vtki, apart from these errors showing up in the notebook the notebook becomes unresponsive (I have to restart the kernel) - but this behavior was probably already present when I originally reported the problem. |
Do you hit the exit button when closing? Could you try using the Looks like this is related to #135 I’ll try to mimic this on a windows machine today |
I can confirm that the error is due to closing via the close window button. Hitting |
I've been thinking about this lately and there should be a way to emulate key-press and mouse-press events, I just have no idea where to start in implementing this. Apologies for all the issues you've been running into - there's a lot of weirdness with Windows on the VTK backend that's difficult for us to catch being Mac and Linux users. Thanks for sticking with Could you please share all your system information? The windows machine I have access to isn't experiencing these bugs, so I wonder if its a GPU-specific, OpenGL version, or system architecture issue. Specifically, please share:
|
No problem, I know that it's often more difficult with Windows in open source, I'm happy to help debugging. :) System information:
|
additional info (as given by
|
I have reproduced this issue on a windows machine I have access to that only has a GTX 1080 GPU All is good on release I'll look into the commit history to see what got changed - there were a ton of changes (from me) that will take quite a while to dig through 😨: 0.17.5...0.18.0 |
Found the culprit in #150 - added a comment on the change that broke the exit button |
@mmagnuski, I presume you have a clone of the repo on your machine? If so, could you checkout the |
Sure, I will check today. |
* Address #186 by not calling to renderer after pressing close button * Fix IPython import * Update notebook testing and test with panel installed * Allow panel tests to fail
@mmagnuski: |
Thanks! BTW, sorry for delay on my side: I saw that you tested it on a windows machine before I got to it so I didn't think my input would be needed. But I have cloned the repo recently and installed in dev mode and can confirm closing the window works without problems now. :) |
@thast is seeing this happen again on Windows |
Closing using the Behavior is consistent with |
Even closing with 'q' has a problem - after closing with 'q' for one window, other windows cannot be opened, just flash and then disappear. |
@WeiGong123, could you share a screen recording of this happening? And a system report: import pyvista as pv
print(pv.Report()) |
Hi Bane, I am not sure whether you can view the screen recording in the ppt file. |
Thanks for sharing that screen recording, @WeiGong123! This is very strange behavior and appears to be a Windows issue - I'll see if I can reproduce this on my Windows VM but it looks like very strange behavior to track down. |
EDIT: this is a duplicate of #135
I've run the example you suggested in my previous issue:
It worked very well but when I closed the window and returned control to the jupyter lab I got the following stream of
list index out of range
errors:The text was updated successfully, but these errors were encountered: