Fix windows closing issues #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
added
bug-fix
priority-high
banesullivan
commented
Dec 14, 2019
GuillaumeFavelier
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
I tested it myself and everything works as expected, great work @banesullivan !
Also, I just saw a few typos.
I'm tempted to add a warning here if the user is on Windows saying:
Please use the q-key to close the Plotting window when using a Windows computer as screenshots may not be properly captured when using the exit button
+1 for a warning or at least a comment about it in the code
|
Okay, this should be good to go now! I added a note about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #501
Resolve #186 and resolve #500 and resolve #418
It's finally figured out and fixed 馃帀 In the GIF below, you can see me use the exit button in the GUI and nothing crashes (#500), THEN I run the next code cell and it doesn't close itself out of nowhere (#186 (comment))!