Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Fix import of example #1424

Merged
merged 1 commit into from
Jun 22, 2021
Merged

➕ Fix import of example #1424

merged 1 commit into from
Jun 22, 2021

Conversation

tkoyama010
Copy link
Member

Overview

➕ Fix import of example

Details

  • None

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

I wonder why this doesn't raise with pytest --doctest-modules...

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #1424 (b68c943) into main (9def273) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1424   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          65       65           
  Lines       12437    12437           
=======================================
  Hits        11200    11200           
  Misses       1237     1237           

@tkoyama010 tkoyama010 merged commit 8d0fe22 into main Jun 22, 2021
adeak added a commit to adeak/pyvista that referenced this pull request Jun 23, 2021
* upstream/main:
  Various minor (and less minor) docfixes (pyvista#1422)
  ➕ Extra import fix of example (pyvista#1425)
  ➕ Fix import of example (pyvista#1424)
  Revert "Use vtk vector mapping from vtkScalarstoColors in add_mesh (pyvista#1387)" (pyvista#1421)
  Enable testing of vtk dev wheels (pyvista#1411)
  rename docs/ --> doc/ (pyvista#1390)
  Fix static checks (pyvista#1418)
  🔗 Fix broken link of list of author (pyvista#1409)
  💬 Let's use GitHub Discussions (pyvista#1395)
  FIX: Fix missing package (pyvista#1398)
  Typo Fix of structured_grid.py (pyvista#1396)
  vtk==9.0.20210612.dev0 fixes and patch leaks (pyvista#1394)
  Allow reversing geodesic paths to the correct order (pyvista#1381)
  Doc Autosummary (pyvista#1386)
  Fix StructuredGrid in streamlines_from_source (pyvista#1374)
@akaszynski akaszynski deleted the fix/import branch June 24, 2021 01:26
@tkoyama010 tkoyama010 added the documentation Anything related to the documentation/website label Oct 8, 2021
@akaszynski akaszynski mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants