Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.33.0 #1995

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Release 0.33.0 #1995

merged 2 commits into from
Jan 5, 2022

Conversation

akaszynski
Copy link
Member

Proposing a release of pyvista==0.33.0.

First step is to bump our main branch version to pyvista==0.34.dev0 in this PR. Next step will be to bump the version in this branch to 0.33.0 and push a tag v0.33.0.

@pyvista/developers if there are any reservations, please let me know.

@akaszynski akaszynski self-assigned this Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1995 (4db5ee2) into main (48a25aa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1995   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          74       74           
  Lines       15520    15520           
=======================================
  Hits        14451    14451           
  Misses       1069     1069           

@tkoyama010
Copy link
Member

Now it is time to use "Automatically generated release notes" . @pyvista/developers Please check that all of your contribution PR have a correct label (See #1712).

@akaszynski
Copy link
Member Author

Now it is time to use "Automatically generated release notes" . @pyvista/developers Please check that all of your contribution PR have a correct label (See #1712).

I'm looking forward to not having to manually generate the description. Thanks @tkoyama010!

@adeak
Copy link
Member

adeak commented Jan 4, 2022

Please check that all of your contribution PR have a correct label (See #1712).

@tkoyama010 thanks. What are the "correct" labels? And since when do we have to check PRs?

I'm looking forward to not having to manually generate the description.

@akaszynski will there be a preview for the release notes we can fine-tune if necessary?

@akaszynski
Copy link
Member Author

akaszynski commented Jan 4, 2022

@akaszynski will there be a preview for the release notes we can fine-tune if necessary?

As far as I can tell, there's no preview (I would have to create a tag first), but you should feel free to open an issue or edit the release notes directly.

Nevermind, you can just manually create a tag with the web interface. Here's what the release notes will look like:


What's Changed

New Features

Bug fixes or behavior changes

Documentation

Maintenance

New Contributors

Full Changelog: 0.27.0...v0.33

@akaszynski
Copy link
Member Author

akaszynski commented Jan 4, 2022

Seems that release notes are generated based on the tag of that branch (main), which we've not done since v0.27 since all of our tags are on release branches. I'm going to have to figure out how to fix that.

@tkoyama010
Copy link
Member

What are the "correct" labels? And since when do we have to check PRs?

@adeak The target PRs are those that have been released since the last release. I have labeled all the PRs, so please make sure that the labeling is correct.

  • enhancement
  • bug
  • documentation
  • maintenance

@akaszynski
Copy link
Member Author

akaszynski commented Jan 5, 2022

Seems that release notes are generated based on the tag of that branch (main), which we've not done since v0.27 since all of our tags are on release branches. I'm going to have to figure out how to fix that.

After creating several tags on main, I'm still not clear on what's causing the issue. There's a long discussion on this here. I'm going to do the lazy thing and delete anything release notes that's prior to the release of 0.32.0

@akaszynski akaszynski merged commit 6fdb9bf into main Jan 5, 2022
@akaszynski akaszynski deleted the release/0.33 branch January 5, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants