Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot to glyphs example #1723

Merged
merged 6 commits into from Nov 2, 2021
Merged

Add plot to glyphs example #1723

merged 6 commits into from Nov 2, 2021

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 added the documentation Anything related to the documentation/website label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1723 (18d5921) into main (26909a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1723   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          71       71           
  Lines       14012    14012           
=======================================
  Hits        12976    12976           
  Misses       1036     1036           

@tkoyama010
Copy link
Member Author

Waiting #1722 (comment) .

Copy link
Member Author

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge main branch after #1728 is merged. CI will be pass after it and we can merge this to main branch.

@tkoyama010 tkoyama010 marked this pull request as ready for review October 18, 2021 01:31
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akaszynski akaszynski merged commit 777b942 into main Nov 2, 2021
@akaszynski akaszynski deleted the doc/add_plot branch November 2, 2021 04:48
adeak added a commit to adeak/pyvista that referenced this pull request Nov 5, 2021
* upstream/main:
  Binary pickling (pyvista#1778)
  Fix docstring examples with broken rendering (pyvista#1770)
  Add plot to glyphs example (pyvista#1723)
  Fix `find_closest_cell` not finding closest cells (pyvista#1740)
  [create-pull-request] update local intersphinx (pyvista#1767)
  UnstructuredGrid add initialization from vtk.vtkPolyData object (pyvista#1756)
  Add enable_stereo_render() and disable_stereo_render() (pyvista#1722)
  cleanup legend (pyvista#1703)
  👷 Add update command to CI build system (pyvista#1728)
  Add release.yml (pyvista#1712)
  Add examples in plotting module (pyvista#1715)
  Fix resetting _wrappers in sphinx-gallery (pyvista#1721)
  Add Tube function (pyvista#1718)
@akaszynski akaszynski mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants