Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make meshio an optional dependency #1939

Merged
merged 4 commits into from Dec 20, 2021
Merged

make meshio an optional dependency #1939

merged 4 commits into from Dec 20, 2021

Conversation

nschloe
Copy link
Contributor

@nschloe nschloe commented Dec 12, 2021

Fixes #1938.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for opening your first pull request in PyVista! 🚀\nPlease make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.\n\nA few things to keep in mind:\n\n- Remember to run the tests locally to make debugging issues easier.\n- If you need help writing tests, take a look at the existing ones for inspiration. If you don not know where to start, let @pyvista/developers know and we will walk you through it.\n- All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.\n- No matter what, we are really grateful that you put in the effort to open this PR! ⭐

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #1939 (0c4278b) into main (9849318) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
- Coverage   29.74%   29.73%   -0.01%     
==========================================
  Files          72       72              
  Lines       14111    14112       +1     
==========================================
- Hits         4197     4196       -1     
- Misses       9914     9916       +2     

@banesullivan
Copy link
Member

Just an FYI if this merges, we need to update the conda-forge recipe

@tkoyama010 tkoyama010 added the maintenance Low-impact maintenance activity label Dec 19, 2021
@akaszynski
Copy link
Member

Just an FYI if this merges, we need to update the conda-forge recipe

Will do on the next release. Thanks for the reminder.

@akaszynski akaszynski merged commit ff64a0e into pyvista:main Dec 20, 2021
@akaszynski akaszynski mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make meshio optional
4 participants